Jira (PUP-1680) "incorrect header check" using Ruby 2

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper commented on an issue   Re: "incorrect header check" using Ruby 2 To reproduce this bug you need to make sure compression is enabled on the puppet master, e.g. apache2 mod_deflate, you're running ruby 2 on the client, and Puppet[:http_compression] is false on the agent. Using debian, I did the following: # a2enmod deflate # vi /etc/apache2/mods-enabled/deflate.conf <IfModule mod_deflate.c> # these are known to be safe with MSIE 6 AddOutputFilterByType DEFLATE text/html text/plain text/xml # everything else may cause problems with MSIE 6 AddOutputFilterByType DEFLATE text/css AddOutputFilterByType DEFLATE application/x-_javascript_ application/_javascript_ application/ecmascript AddOutputFilterByType DEFLATE application/rss+xml SetOutputFilter DEFLATE </IfModule> Added a file resource with a remote source parameter (just leveraging a module I already had installed): # vi /etc/puppet/manifests/site.pp file { '/tmp/concatfragments.rb': ensure => file, source => 'puppet:///modules/concat/concatfragments.rb' } # service apache2 restart On agent, make sure the destination file doesn't exist, and run the agent, it should fail as expected: $ bundle exec puppet agent -t ... Error: Could not set 'file' on ensure: incorrect header check at 4:/etc/puppet/manifests/site.pp Error: Could not set 'file' on ensure: incorrect header check at 4:/etc/puppet/manifests/site.pp Wrapped exception: incorrect header check Error: /Stage[main]/Main/File[/tmp/concatfragments.rb]/ensure: change from absent to file failed: Could not set 'file' on ensure: incorrect header check at 4:/etc/puppet/manifests/site.pp The workaround is to enable Puppet[:http_compression]. Note the property is false by default, and since it's a boolean type setting, you must specify --http_compression on the command line to enable it: $ bundle exec puppet agent -t --http_compression ... Notice: /Stage[main]/Main/File[/tmp/concatfragments.rb]/ensure: defined content as '{md5}6784c28044a4204efb75fe4eb759816a' With the fix applied, the agent should download the compressed file correctly (both in the default case when Puppet[:http_compression] is false, and when the setting is set to true): $ bundle exec puppet agent -t ... Notice: /Stage[main]/Main/File[/tmp/concatfragments.rb]/ensure: defined content as '{md5}6784c28044a4204efb75fe4eb759816a' $ rm /tmp/concatfragments.rb $ bundle exec puppet agent -t --http_compression ... Notice: /Stage[main]/Main/File[/tmp/concatfragments.rb]/ensure: defined content as '{md5}6784c28044a4204efb75fe4eb759816a' Add Comment   Puppet / PUP-1680 "incorrect header check" using Ruby 2 I haven't found anything out there so far, so I thought I'd just document it while I'm at it. We ran into some other problem with the changes in net/http Ruby 2.1.0 introduced around the handling of gzip/deflate encoded content. This MIGHT be related. So far we haven't been able to fix it. {code} Error: incorrect header check Error: /Stage[main]/... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.