Jira (PUP-3135) Square brackets in file names not handled properly

[Charlie Sharpsteen (JIRA)]

Title: Message Title

Charlie Sharpsteen commented on an issue   Re: Square brackets in file names not handled properly This won't be resolved by PUP-2700 as that ticket concerned double-escaping URIs for FIle sources. The cause of this issue runs quite a bit deeper and has been with Puppet for a while. The issue is that we specify source as a single string which is run through a fairly limited URI.escape filter. Using a more aggressive filter is not feasible as the alternatives also encode significant separators like : and /. Really, instead of having the source as one giant string: file { ... source => 'puppet:///modules/some_module/a_path[/with_lots_of_stuff?.txt', } We need to be able to split the scheme, server, and Puppet mount point from the actual file path that is being retrieved. Something like: file { ... source => 'puppet:///modules/some_module', source_path => 'a_path[/with_lots_of_stuff?.txt', } Then we could hit source_path with a very aggressive filter like CGI.escape which clobbers all special characters and can handle UTF-8 in addition to ASCII. So, as it stands, all the data is currently rolled up in one big URI which we would need to parse in order to separate out the scheme, server, Puppet mount point and remote file path so that the file path can be properly encoded. BUT... special characters may render the URI unparsable. We might be able to apply some assumptions, such as assuming source URIs will never contain query strings; but the core problem of separating the file path from the source URI so that it can be properly escaped may be a catch-22 with the way the data is currently presented. Add Comment   Puppet / PUP-3135 Square brackets in file names not handled properly When trying to transfer a file (directly or as part of a recursive transfer) using the file resource that contains a square bracket '[' character. This issue arose when automating a cygwin installation where files like [.exe and [.1.gz are part of the regular installation. This issue seems related to PUP-2700, unfortunately many special characters were... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.