Jira (PUP-2862) Validate that default value expression for param does not define variable

[Henrik Lindberg (JIRA)]

Title: Message Title

Henrik Lindberg commented on an issue   Re: Validate that default value _expression_ for param does not define variable This is low hanging fruit for someone that wants to implement a validation rule for the language. Add a Issue :hard_issue (or reuse something generic if there is one "you cannot do that here") in the check_Parameter(o) rule, assert that its default _expression_ does not contain an AssignmentExpression by: if o.value.is_a?(AssignmentExpression) || ! the_param.value.eAllContents.any? {|model| model.is_a? AssignmentExpression } acceptor.accept(...) # trigger the issue end ALTERNATIVELY if you think there are going to be more expressions that are pathological in this position, use a polymorphic dispatcher Copy one of the dispatchers, give it a name e.g. "param_expr", implement two polymorphic methods, and one that invokes it: def param_expr_Object(o) { } # do nothing, it is ok def param_expr_AssignmentExpression(o) { acceptor.accept(...) # trigger the issue } def param_expr(model) { param_expr_visitor.visit_this0(self, model) model.eAllContents.each {|m| param_expr_visitor.visit_this0(self, m) } Add Comment   Puppet / PUP-2862 Validate that default value _expression_ for param does not define variable If an parameterized entity has a parameter with a default value _expression_, that _expression_ may not include assignment expressions as it is undefined in which scope that variable is introduced. This should be validated as an error. {code} define foo ($a = ($b = 10)) {code} This will set {{$b}} in the enclosing scope of the define! This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.