Jira (PUP-3239) Add a validate method to Puppet::Node::Environment so the Compiler can easily halt for environments with bad configuration.

[Joshua Partlow (JIRA)]

Title: Message Title

Joshua Partlow created an issue   Puppet / PUP-3239 Add a validate method to Puppet::Node::Environment so the Compiler can easily halt for environments with bad configuration. Issue Type: Improvement Affects Versions: 3.7.1 Assignee: Andy Parker Components: DSL Created: 12/Sep/14 1:46 PM Priority: Normal Reporter: Joshua Partlow There are various cases where an environment's final configuration may end up being invalid. One case, where an environment may have conflicting manifest settings, is already covered by a Puppet::Node::Environment#conflicting_manifest_settings? method, added in PUP-3069 . Another case brought up by PUP-3162 has to do with base environment settings like environmentpath or basemodulepath having been set with a $environment in them. This interpolation was disallowed in PUP-3162 , and we log a warning if it's encountered, but do not stop the master from initializing. As Kurt pointed out in PUP-3162 , this can lead to an agent run looking like the following: # puppet apply -e 'notify { $environment: }' --environment nonesuch --debug /usr/local/lib/site_ruby/1.9.1/puppet/application.rb:365:in `run': Could not find a directory environment named 'nonesuch' anywhere in the path: /etc/puppet/environments/$environment. Does the directory exist? (Puppet::Environments::EnvironmentNotFound) from /usr/local/lib/site_ruby/1.9.1/puppet/util/command_line.rb:146:in `run' from /usr/local/lib/site_ruby/1.9.1/puppet/util/command_line.rb:92:in `execute' from /usr/bin/puppet:8:in `<main>' While it's true that the environment can't be found, the message is confusing if the user is expecting that path to interpolate. It would be better to make a general Puppet::Node::Environment#valid? method that handles the conflicting_manifests_settings? check, the interpolation cases, and which can be expanded as needed for other environment tests in the future. Add Comment   This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.