Jira (PUP-3328) tidy should follow symlinks

[Cosmin Lehene (JIRA)]

Title: Message Title

Cosmin Lehene created an issue   Puppet / PUP-3328 tidy should follow symlinks Issue Type: Bug Affects Versions: 3.x Assignee: Cosmin Lehene Components: Types and Providers Created: 22/Sep/14 5:40 PM Fix Versions: 3.7.2 Priority: Normal Reporter: Cosmin Lehene tidy uses Fileset which will use either stat or lstat (see code ) depending on :links => :manage | :follow and defaults to {{:manage }}(see code ) As tidy doesn't explicitly set :follow the results may vary if the target dir is a symlink. For example, if trying to tidy /etc/init.d which is a symlink to /etc/rc./d/init.d on CentOS 6/7 it won't work. However tidying /etc/init.d/ (trailing slash) will work. Again this is consistent with how stat/lstat works [root@localhost puppet]# stat /etc/init.d/ File: ‘/etc/init.d/’ Size: 4096 Blocks: 8 IO Block: 4096 directory Device: fd01h/64769d Inode: 75105 Links: 2 Access: (0755/drwxr-xr-x) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2014-09-23 05:22:27.351955472 +0900 Modify: 2014-09-17 03:34:15.521690654 +0900 Change: 2014-09-17 03:34:15.521690654 +0900 Birth: - [root@localhost puppet]# stat /etc/init.d File: ‘/etc/init.d’ -> ‘rc.d/init.d’ Size: 11 Blocks: 0 IO Block: 4096 symbolic link Device: fd01h/64769d Inode: 67139111 Links: 1 Access: (0777/lrwxrwxrwx) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2014-09-23 02:08:38.295890037 +0900 Modify: 2014-08-18 02:53:43.335191310 +0900 Change: 2014-08-18 02:53:43.335191310 +0900 Birth: - [root@localhost puppet]# stat -L /etc/init.d File: ‘/etc/init.d’ Size: 4096 Blocks: 8 IO Block: 4096 directory Device: fd01h/64769d Inode: 75105 Links: 2 Access: (0755/drwxr-xr-x) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2014-09-23 05:22:27.351955472 +0900 Modify: 2014-09-17 03:34:15.521690654 +0900 Change: 2014-09-17 03:34:15.521690654 +0900 Birth: - Instead tidy should explicitly set :links => :follow or at least have it configurable (or both). Add Comment   This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.