Jira (HI-223) Hiera 'deeper' merge knockout only knocks out from closest array

[Alex Elman (JIRA)]

Title: Message Title

Alex Elman commented on an issue   Re: Hiera 'deeper' merge knockout only knocks out from closest array So this is expected behavior based on the interaction between the deep_merge gem and the hiera gem. In order to achieve the functionality we're looking for, there are really two approaches that could be taken. Make changes to hiera gem to make sure that the destination array has an item that the source array can knock out. If it doesn't, then remember the knockout item and stick it back into the source array on subsequent calls to deep_merge. Make changes to the deep_merge gem to allow for a way to pass through the knockout item if there wasn't anything in the destination array to knock out. Option 2 is better than option 1 because all of the knockout logic is in the deep_merge gem other uses of the deep_merge gem might benefit from this functionality it's simpler to implement I made changes to the deep_merge gem and wrote test cases and I intend to open a merge request when my testing is complete. For the curious, my changes are here: https://github.com/pkill/deep_merge/commit/4967c0f49016690c208146d581f6f58d5a7254dc Feel free to close this issue as won't fix. Add Comment   Hiera / HI-223 Hiera 'deeper' merge knockout only knocks out from closest array Consider the following hiera structure: host.yaml {code} stuff:      - ---alpha      - ---beta      - gamma {code} datacenter.yaml {code} stuff:      - alpha {code} global.yaml {code} stuff:      - beta {code} Where the hierarchy is: {code} :hierarchy:      - host      - datacenter      - global {code} What you'd expect ... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.