Jira (PUP-3381) directoryservice provider creates users with low ids

Dustin J. Mitchell (JIRA) Thu, 02 Oct 2014 11:41:15 -0700

Title: Message Title

Dustin J. Mitchell commented on an issue

Worth noting, too, that the comment above next_system_id is a lie:

  # Get the next available uid on the system by getting a list of user ids,

  # sorting them, grabbing the last one, and adding a 1. Scientific stuff here.

  def next_system_id(min_id=20)

    dscl_output = dscl '.', '-list', '/Users', 'uid'

    # We're ok with throwing away negative uids here. Also, remove nil values.

    user_ids = dscl_output.split.compact.collect { |l| l.to_i if l.match(/^\d+$/) }

    ids = user_ids.compact!.sort! { |a,b| a.to_f <=> b.to_f }

    # We're just looking for an unused id in our sorted array.

    ids.each_index do |i|

      next_id = ids[i] + 1

      return next_id if ids[i+1] != next_id and next_id >= min_id

end

end

In fact, it looks for the lowest unused id greater than any existing id.

Add Comment

Puppet /

PUP-3381

If a uid is not specified, the automatically selected uid is very low (<100) and sometimes produces broken users. On a fresh 10.8.5 install it creates a new user with uid 28 and then createhomedir for the user fails.

New users created in the OSX GUI have uids starting at 501, I think puppet should do the same when the uid is not specified.

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3381) directoryservice provider creates users with low ids

Reply via email to