Jira (PUP-3365) consider not doing deep undef to empty string map in 3x function API

[Andy Parker (JIRA)]

Title: Message Title

Andy Parker commented on an issue   Re: consider not doing deep undef to empty string map in 3x function API While reviewing the code I wanted to try out how this worked. I write a 3x function called dumpjson that does what its name implies. I also wrote a corresponding 4x function called lib4::dumpjson. [17:40:47][Ruby(ruby-1.9.3-p484)][Git(pr/3142)] andy:puppet > be puppet apply -e 'notice(lib4::dumpjson({ a => undef, b => $x, c => "", d => [undef, $x, ""] }))' --parser future Notice: Scope(Class[main]): {"a":null,"b":null,"c":"","d":[null,null,""]} Notice: Compiled catalog for aparker.corp.puppetlabs.net in environment production in 0.48 seconds Notice: Finished catalog run in 0.04 seconds [17:41:02][Ruby(ruby-1.9.3-p484)][Git(pr/3142)] andy:puppet > be puppet apply -e 'notice(lib4::dumpjson({ a => undef, b => $x, c => "", d => [undef, $x, "", Schedule[daily]] }))' --parser future Notice: Scope(Class[main]): {"a":null,"b":null,"c":"","d":[null,null,"","Schedule['daily']"]} Notice: Compiled catalog for aparker.corp.puppetlabs.net in environment production in 0.49 seconds Notice: Finished catalog run in 0.04 seconds [17:44:00][Ruby(ruby-1.9.3-p484)][Git(pr/3142)] andy:puppet > be puppet apply -e 'notice(dumpjson({ a => undef, b => $x, c => "", d => [undef, $x, "", Schedule[daily]] }))' --parser future Notice: Scope(Class[main]): {"a":"undef","b":"undef","c":"","d":["undef","undef","",{"type":"Schedule","title":"daily","tags":["schedule","daily"],"exported":false}]} Notice: Compiled catalog for aparker.corp.puppetlabs.net in environment production in 0.53 seconds Notice: Finished catalog run in 0.04 seconds [17:44:15][Ruby(ruby-1.9.3-p484)][Git(pr/3142)] andy:puppet > be puppet apply -e 'notice(dumpjson({ a => undef, b => $x, c => "", d => [undef, $x, "", Schedule[daily]] }))' --parser current Notice: Scope(Class[main]): {"a":"undef","b":"undef","c":"","d":["undef","undef","",{"type":"Schedule","title":"daily","tags":["schedule","daily"],"exported":false}]} Notice: Compiled catalog for aparker.corp.puppetlabs.net in environment production in 0.02 seconds Notice: Finished catalog run in 0.05 seconds [17:45:14][Ruby(ruby-1.9.3-p484)][Git(pr/3142)] andy:puppet > be puppet apply -e 'notice(dumpjson({ a => undef, b => $x, c => "", d => [undef, $x, "", "Schedule[daily]"] }))' --parser current Notice: Scope(Class[main]): {"a":"undef","b":"undef","c":"","d":["undef","undef","","Schedule[daily]"]} Notice: Compiled catalog for aparker.corp.puppetlabs.net in environment production in 0.02 seconds Notice: Finished catalog run in 0.04 seconds [17:49:31][Ruby(ruby-1.9.3-p484)][Git(pr/3142)] andy:puppet > be puppet apply -e '$y = Schedule[daily] notice(dumpjson({ a => undef, b => $x, c => "", d => [undef, $x, "", $y, Schedule[daily]] }))' --parser current Notice: Scope(Class[main]): {"a":"undef","b":"undef","c":"","d":["undef","undef","",{"type":"Schedule","title":"daily","tags":["schedule","daily"],"exported":false},{"type":"Schedule","title":"daily","tags":["schedule","daily"],"exported":false}]} Notice: Compiled catalog for aparker.corp.puppetlabs.net in environment production in 0.03 seconds Notice: Finished catalog run in 0.05 seconds I find some of those outputs very strange, but they are consistent between future and current for the 3x function. Add Comment   Puppet / PUP-3365 consider not doing deep undef to empty string map in 3x function API With the future parser in 3.7, all arguments to 3x functions are deeply mapped to translate undef to empty strings. This is different than how the 3x runtime does this, where only the surface undefs are mapped (not if they are in arrays or hashes). This causes problems in existing functions such as {{ensure_resource}}. While we should move functions... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.