Jira (PUP-3351) Puppet evaluates classes declared with parameters before classes declared without parameters

[Britt Gresham (JIRA)]

Title: Message Title

Britt Gresham commented on an issue   Re: Puppet evaluates classes declared with parameters before classes declared without parameters In this functional review I made sure that classes with additional params passed in were evaluated before those without params when inherited by another class and specified by an ENC. You can see below that when ran using Puppet 3.7.1 we get an error complaining that Class['one'] has already been defined as opposed to Puppet at the merge commit where puppet evaluates Class['one'] before Class['two']. The 'something' message that is shown proves that Class['one'] is evaluated before because the message emitted was not the default 'default_two' that was defined in the class definition. /Users/britt/projects/ruby/puppet/enc #!/bin/bash cat << ENC classes: two: one: foo: something ENC modules/one/manifests/init.pp class one ($foo = "default_two") { $something = $foo notify { 'one': } } modules/two/manifests/init.pp class two inherits one { notify { $one::something: } } In Puppet 3.7.1 britt at BrittMac in ~/projects/ruby/puppet on (detached from 3.7.1)* $ be puppet apply ./test.pp --node_terminus=exec --external_nodes=/Users/britt/projects/ruby/puppet/enc Error: Duplicate declaration: Class[One] is already declared; cannot redeclare on node brittmac.delivery.puppetlabs.net Error: Duplicate declaration: Class[One] is already declared; cannot redeclare on node brittmac.delivery.puppetlabs.net In Puppet at e19552 britt at BrittMac in ~/projects/ruby/puppet on (detached from upstream/stable)* $ be puppet apply ./test.pp --node_terminus=exec --external_nodes=/Users/britt/projects/ruby/puppet/enc Notice: Compiled catalog for brittmac.delivery.puppetlabs.net in environment production in 0.01 seconds Notice: one Notice: /Stage[main]/One/Notify[one]/message: defined 'message' as 'one' Notice: something Notice: /Stage[main]/Two/Notify[something]/message: defined 'message' as 'something' Notice: Finished catalog run in 0.18 seconds Add Comment   Puppet / PUP-3351 Puppet evaluates classes declared with parameters before classes declared without parameters When evaluating classes from an external node classifier, Puppet evaluates the set of those declared without parameters prior to the set of those declared with class parameters. This is a problem because this ordering causes "Error: Duplicate declaration" more commonly. In addition, the behavior is in contradiction to the code comment of, "This means cl... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.