Jira (FACT-720) Memoize WMI queries

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper created an issue   Facter / FACT-720 Memoize WMI queries Issue Type: Bug Affects Versions: FACT 2.2.0 Assignee: Eric Sorenson Created: 08/Oct/14 11:36 AM Labels: windows Priority: Normal Reporter: Josh Cooper Facter is very slow on windows, because the WMI queries are executed multiple times, especially the ip related facts due to FACT-449. On my system with 3 network adapters, I see 71 WMI queries, and it takes nearly 10 seconds to execute C:\work\facter> (Measure-Command { bundle exec facter }).totalseconds 9.8878893 If we look at the WMI queries being executed, there are many duplicates: SELECT FROM Win32_NetworkAdapterConfiguration WHERE Index = 14 SELECT FROM Win32_NetworkAdapterConfiguration WHERE Index = 15 SELECT FROM Win32_NetworkAdapterConfiguration WHERE Index = 7 SELECT * FROM Win32_NetworkAdapter WHERE Index = 14 AND NetEnabled = TRUE SELECT * FROM Win32_NetworkAdapter WHERE Index = 14 AND NetEnabled = TRUE SELECT * FROM Win32_NetworkAdapter WHERE Index = 14 AND NetEnabled = TRUE SELECT * FROM Win32_NetworkAdapter WHERE Index = 15 AND NetEnabled = TRUE SELECT * FROM Win32_NetworkAdapter WHERE Index = 15 AND NetEnabled = TRUE SELECT * FROM Win32_NetworkAdapter WHERE Index = 15 AND NetEnabled = TRUE SELECT * FROM Win32_NetworkAdapter WHERE Index = 7 AND NetEnabled = TRUE SELECT * FROM Win32_NetworkAdapter WHERE Index = 7 AND NetEnabled = TRUE SELECT * FROM Win32_NetworkAdapter WHERE Index = 7 AND NetEnabled = TRUE SELECT Description, ServiceName, IPAddress, IPConnectionMetric, InterfaceIndex, Index, IPSubnet, MACAddress, MTU, Settin gID FROM Win32_NetworkAdapterConfiguration WHERE IPConnectionMetric IS NOT NULL AND IPEnabled = TRUE SELECT Description, ServiceName, IPAddress, IPConnectionMetric, InterfaceIndex, Index, IPSubnet, MACAddress, MTU, Settin gID FROM Win32_NetworkAdapterConfiguration WHERE IPConnectionMetric IS NOT NULL AND IPEnabled = TRUE SELECT Description, ServiceName, IPAddress, IPConnectionMetric, InterfaceIndex, Index, IPSubnet, MACAddress, MTU, Settin gID FROM Win32_NetworkAdapterConfiguration WHERE IPConnectionMetric IS NOT NULL AND IPEnabled = TRUE SELECT Description, ServiceName, IPAddress, IPConnectionMetric, InterfaceIndex, Index, IPSubnet, MACAddress, MTU, Settin gID FROM Win32_NetworkAdapterConfiguration WHERE IPConnectionMetric IS NOT NULL AND IPEnabled = TRUE SELECT Description, ServiceName, IPAddress, IPConnectionMetric, InterfaceIndex, Index, IPSubnet, MACAddress, MTU, Settin gID FROM Win32_NetworkAdapterConfiguration WHERE IPConnectionMetric IS NOT NULL AND IPEnabled = TRUE SELECT Description, ServiceName, IPAddress, IPConnectionMetric, InterfaceIndex, Index, IPSubnet, MACAddress, MTU, Settin gID FROM Win32_NetworkAdapterConfiguration WHERE IPConnectionMetric IS NOT NULL AND IPEnabled = TRUE SELECT Description, ServiceName, IPAddress, IPConnectionMetric, InterfaceIndex, Index, IPSubnet, MACAddress, MTU, Settin gID FROM Win32_NetworkAdapterConfiguration WHERE IPConnectionMetric IS NOT NULL AND IPEnabled = TRUE SELECT IPAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 14 SELECT IPAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 14 SELECT IPAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 14 SELECT IPAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 15 SELECT IPAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 15 SELECT IPAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 15 SELECT IPAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 7 SELECT IPAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 7 SELECT IPAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 7 SELECT IPSubnet FROM Win32_NetworkAdapterConfiguration WHERE Index = 14 SELECT IPSubnet FROM Win32_NetworkAdapterConfiguration WHERE Index = 14 SELECT IPSubnet FROM Win32_NetworkAdapterConfiguration WHERE Index = 15 SELECT IPSubnet FROM Win32_NetworkAdapterConfiguration WHERE Index = 15 SELECT IPSubnet FROM Win32_NetworkAdapterConfiguration WHERE Index = 7 SELECT IPSubnet FROM Win32_NetworkAdapterConfiguration WHERE Index = 7 SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection 2' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection 2' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection 2' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection 2' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection 2' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection 2' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection 2' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection 3' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection 3' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection 3' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection 3' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection 3' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection 3' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection 3' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection' SELECT MACAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 14 SELECT MACAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 15 SELECT MACAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 7 SELECT Version from Win32_OperatingSystem SELECT manufacturer, model FROM Win32_ComputerSystem SELECT version, producttype FROM Win32_OperatingSystem SELECT version, producttype FROM Win32_OperatingSystem SELECT version, producttype FROM Win32_OperatingSystem select * from Win32_OperatingSystem select * from Win32_Processor select * from Win32_Processor select Architecture, Level, AddressWidth from Win32_Processor select DNSDomain from Win32_NetworkAdapterConfiguration where IPEnabled = True select FreePhysicalMemory from Win32_OperatingSystem select Name from Win32_Processor select TotalPhysicalMemory from Win32_ComputerSystem Simply memoizing the WMI queries results in 3.8 execution time: C:\work\facter> (Measure-Command { bundle exec facter }).totalseconds 3.8455539 and only executes: SELECT FROM Win32_NetworkAdapterConfiguration WHERE Index = 14 SELECT FROM Win32_NetworkAdapterConfiguration WHERE Index = 15 SELECT FROM Win32_NetworkAdapterConfiguration WHERE Index = 7 SELECT * FROM Win32_NetworkAdapter WHERE Index = 14 AND NetEnabled = TRUE SELECT * FROM Win32_NetworkAdapter WHERE Index = 15 AND NetEnabled = TRUE SELECT * FROM Win32_NetworkAdapter WHERE Index = 7 AND NetEnabled = TRUE SELECT Description, ServiceName, IPAddress, IPConnectionMetric, InterfaceIndex, Index, IPSubnet, MACAddress, MTU, Settin gID FROM Win32_NetworkAdapterConfiguration WHERE IPConnectionMetric IS NOT NULL AND IPEnabled = TRUE SELECT IPAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 14 SELECT IPAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 15 SELECT IPAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 7 SELECT IPSubnet FROM Win32_NetworkAdapterConfiguration WHERE Index = 14 SELECT IPSubnet FROM Win32_NetworkAdapterConfiguration WHERE Index = 15 SELECT IPSubnet FROM Win32_NetworkAdapterConfiguration WHERE Index = 7 SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection 2' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection 3' SELECT Index FROM Win32_NetworkAdapter WHERE NetConnectionID = 'Local Area Connection' SELECT MACAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 14 SELECT MACAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 15 SELECT MACAddress FROM Win32_NetworkAdapterConfiguration WHERE Index = 7 SELECT Version from Win32_OperatingSystem SELECT manufacturer, model FROM Win32_ComputerSystem SELECT version, producttype FROM Win32_OperatingSystem select * from Win32_OperatingSystem select * from Win32_Processor select Architecture, Level, AddressWidth from Win32_Processor select DNSDomain from Win32_NetworkAdapterConfiguration where IPEnabled = True select FreePhysicalMemory from Win32_OperatingSystem select Name from Win32_Processor select TotalPhysicalMemory from Win32_ComputerSystem Which is more than twice as fast (9.6/3.8). There still are some duplicate queries, e.g. we query for IPAddress, IPSubnet, etc for each interface instead of making one query for all of that information. But that can't be fixed without restructuring the ip related facts, which we're not going to do in ruby facter. Add Comment   This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.