Jira (PUP-3439) PMT can't accept deflate (zlib) compressed content from the forge

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper created an issue   Puppet / PUP-3439 PMT can't accept deflate (zlib) compressed content from the forge Issue Type: Bug Affects Versions: PUP 3.7.1 Assignee: Kylo Ginsberg Components: Client, Networking Services, PMT Created: 10/Oct/14 10:55 AM Priority: Normal Reporter: Josh Cooper When the PMT tool connects to the forge, it sends HTTP headers indicating it supports both gzip and deflate (zlib) compression formats equally. However, if the PMT tool is given deflate (zlib), it will choke with: Error: unknown compression method /Users/josh/work/puppet/lib/puppet/forge/repository.rb:105:in `inflate' /Users/josh/work/puppet/lib/puppet/forge/repository.rb:105:in `block in read_response' /Users/josh/.rbenv/versions/1.9.3-p545/lib/ruby/1.9.1/net/http.rb:746:in `start' /Users/josh/work/puppet/lib/puppet/forge/repository.rb:94:in `read_response' /Users/josh/work/puppet/lib/puppet/forge/repository.rb:48:in `make_http_request' /Users/josh/work/puppet/lib/puppet/forge.rb:114:in `make_http_request' /Users/josh/work/puppet/lib/puppet/forge.rb:98:in `fetch' Adrien Thebo discovered that rack (which the forge-api service uses) uses: https://github.com/rack/rack/blob/master/lib/rack/deflater.rb#L108-L109 And if we modify the PMT to do: Zlib::Inflate.new(-Zlib::MAX_WBITS).inflate(response.read_body) then it works correctly. Add Comment   This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.