Jira (PUP-3514) Future parser not showing line/column for error

[Henrik Lindberg (JIRA)]

Title: Message Title

Henrik Lindberg commented on an issue   Re: Future parser not showing line/column for error This problem is the same for all errors that come from the simplistic semantic checks in the future parser. We have a different ticket (PUP-1546) about improving those error messages (the parser does not have the same nice infrastructure (yet) to use the 4x issue system and its messages can not include semantic information about the type of _expression_ etc. That will change at some point during 4x. The implementation of the error method is simply dead wrong - it behaves like the 3x version and ends up calling to_s on an AST model that is contructed !!! as the result of invoking operations on the AST Factory!!! when it believes it is getting file, line etc. it is instead creating a program to extract those - that is the output you are seeing! Amazed that we do not have unit testing to cover those errors. The fix of the problem is quite simple (I already have it working), but adding tests for all the corner cases is a lot more work. Will add one for the specific case though to catch a regression of the fundamental problem that the parser's error method was misbehaving. Andy Parker do you want this targeted for 3.7.3? (I think it is pretty bad) - I did the work off stable Add Comment   Puppet / PUP-3514 Future parser not showing line/column for error We had a manifest that contains this: {code} File ['/etc/pam.d/sshd'] { {code} Obviously the space there is a mistake but the future parser gave me this back: {noformat} Error: Could not parse for environment production: _expression_ is not valid as a resource, resource-default, or resource-override at (slice () 'file'):(slice () 'line'):(slice ... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.