Jira (FACT-752) External powershell Facts are executed on unix hosts

[William Hopper (JIRA)]

Title: Message Title

William Hopper commented on FACT-752   Re: External powershell Facts are executed on unix hosts Some context from a bit of debugging: It looks like we're not actually trying to execute the file in the case of non-executable scripts, rather Facter is just generically warning that it failed to find a parser for the file. Before loading an external fact, the external fact parser utility does a check to see what sort of fact we might have based on filename, and the only way it can know if a file is a script is if it's executable. If it is not executable and is not something like a .txt file or .json file, the parser defaults to creating a NothingParser, which just returns nil, the same as what happens when there's an error parsing something like a JSON file. This presents sort of a messy problem where we don't know why Facter failed to get a result from the file it found in its external fact directory. Either it actually failed to parse the file, or the file was non-executable and didn't fall into any of the non-script parsers like JSON or txt. It could also mean that the file was a directory. In any of these cases, Facter outputs the same warning as seen above: 61 data = ""> ... 64 elsif data == {} or data == nil 65 Facter.warn "Fact file #{file} was parsed but returned an empty data set" data will be nil in one of several cases: A failed JSON.load The file is a directory The file is not executable on a Unix system and doesn't qualify for any of the other parsers (JSON, yaml, txt...) The file does not have a typical Windows script extension in Windows This means we'll get this warning in several unrelated cases, which is misleading. Playing around with the code, it seems as though a bit of a refactor might be necessary to get around the issue of not knowing whether a file is a script or not. Add Comment   This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.