Jira (PUP-3300) Rework Puppet::Util::Checksums to not extend itself

[Kurt Wall (JIRA)]

Title: Message Title

Kurt Wall commented on PUP-3300   Re: Rework Puppet::Util::Checksums to not extend itself Adrien Thebo ++ Verified in master at SHA=03a279c3598554c309e0567a5e00c161e422ea04. After changing both the master and agent have to use digest_algorithm = sha256, then bouncing the master service, this works as expected. Installing a module and running the agent: # puppet module install puppetlabs-stdlib Notice: Preparing to install into /etc/puppet/modules ... Notice: Downloading from https://forgeapi.puppetlabs.com ... Notice: Installing -- do not interrupt ... /etc/puppet/modules └── puppetlabs-stdlib (v4.4.0) # puppet agent --test Info: Retrieving pluginfacts Info: Retrieving plugin Notice: /File[/var/lib/puppet/lib/facter]/ensure: created Notice: /File[/var/lib/puppet/lib/facter/facter_dot_d.rb]/ensure: defined content as '{sha256}84f07560460425a6a148cafc860965770e69025d880826831106f03fcd78d389' Notice: /File[/var/lib/puppet/lib/facter/pe_version.rb]/ensure: defined content as '{sha256}27498d481b63291c84537447ce5d0545a3406a458321a25324e7040fd163013d' [...] If I then change digest_algorithm to md5, there is no user-visible change: # puppet agent --test Info: Retrieving pluginfacts Info: Retrieving plugin Info: Loading facts Info: Caching catalog for v2yys5yqte8wck5.delivery.puppetlabs.net Info: Applying configuration version '1416339057' But if I install another module and do another agent run, you can see the algorithm in use is now m5: Info: Retrieving pluginfacts Info: Retrieving plugin Notice: /File[/var/lib/puppet/lib/facter/apt_update_last_success.rb]/ensure: defined content as '{md5}2926ff059cd2f63a2a7824ba898837f9' Notice: /File[/var/lib/puppet/lib/facter/apt_updates.rb]/ensure: defined content as '{md5}51c7c4e4ef3cb40bb9a8f083671c36ea' Notice: /File[/var/lib/puppet/lib/facter/concat_basedir.rb]/ensure: defined content as '{md5}ff080677e7f192b9b96911698b0b9b3d' Add Comment   This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.