Jira (FACT-380) Private ipaddress is used as ipaddress fact

[Adam T Backer (JIRA)]

Title: Message Title

Adam T Backer commented on FACT-380   Re: Private ipaddress is used as ipaddress fact I dont think factor should ignore private ip addresses. This would eliminate a lot of use cases. I think the proper logic for "$ipaddress" should be to assign the ip address of the interface that provides access to the default route. so, in this case: root@dns101:~$ ip route show|grep default default via 10.7.119.254 dev eth0 ipaddress == ipaddress_eth0 Certainly picking the highest alphabetical is very unlikely to produce a value for $ipaddress that would be desired. Given that we have $ipaddress_$ {interface} for all interfaces, the only thing potentially missing would be a variable that defines the ip address on an interface for each configured route. i.e. given: xoom@dns101:~$ ip route show default via 10.7.119.254 dev eth0 10.7.112.0/21 dev eth0 proto kernel scope link src 10.7.113.1 172.17.0.0/16 dev docker0 proto kernel scope link src 172.17.42.1 we would set $ipaddress = $ipaddress_eth0 $ipaddress_172_17_0_0_16 = $ipaddress_docker0 $ipaddress_10_7_112_0_21 = $ipaddress_eth0 This way you can enumerate the external representation of your host (discounting NAT, obviously) to a particular network while being agnostic of the interface on which it is applied. If this proves to be desired logic, I would happily provide a patch. Add Comment   This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.