Jira (PUP-3780) Verify Ruby 2.1.5 compatibility on Windows 2003

[Ethan Brown (JIRA)]

Title: Message Title

Ethan Brown commented on PUP-3780   Re: Verify Ruby 2.1.5 compatibility on Windows 2003 Well, this is bad news. Looks like we could have saved ourselves some time as there is new discussion on GitHub for this precise issue at https://github.com/oneclick/rubyinstaller/issues/239 https://github.com/oneclick/rubyinstaller/issues/251 Based on 239, another person was able to build Ruby on XP, but had to disable networking to do so (effectively making the build useless). As Josh Cooper and I had discovered while looking at the Ruby source, it's a compile-time #ifdef rather than a runtime check used to determine if _localtime64_s and _gmtime64_s can be used or not. #if RUBY_MSVCRT_VERSION >= 80 || defined(HAVE__GMTIME64_S) e = gmtime_s(rp, tp); if (e != 0) goto error; #else .... https://github.com/ruby/ruby/blob/fa13cb050db8091658007df77f8247ae02442e51/win32/win32.c#L7140-L7143 https://github.com/ruby/ruby/blob/fa13cb050db8091658007df77f8247ae02442e51/win32/win32.c#L7164-L7167 It does seems peculiar that the 32-bit version tries to use these 64-bit functions - but I think it's due to Ruby insisting on creating definitions for these 64-bit functions when MINGW_HAS_SECURE_API is not defined: https://github.com/ruby/ruby/blob/fa13cb050db8091658007df77f8247ae02442e51/win32/win32.c#L7122-L7125 The big question mark for me is where is HAVE_GMTIME64_S defined? Is this a MinGW define perhaps? I think the solution here is to attempt to build on 2003 x64 with an RUBY_MSVCRT_VERSION < 80 and with HAVE_GMTIME64_S undefined... which may be something we have to forcefully do. Do you think that this is feasible Melissa Stone / Geoff Nichols / Rob Braden given our current Windows native toolchains for building Ruby? //cc Kylo Ginsberg Michael Smith Peter Huene for any additional suggestions that my rusty C++ skills may have overlooked. FWIW, the V8 devs ran into similar issues building with MinGW on XP where secure functions are not available in MSVCRT and this is their solution (essentially undefining MINGW_HAS_SECURE_API and using their own definitions), which shouldn't work for based on what the Ruby code is doing: https://groups.google.com/forum/#!topic/v8-dev/xT8JJrCRFjo Add Comment   This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.