Jira (PUP-3916) File type downloads file content twice when diffs are enabled

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper created an issue   Puppet / PUP-3916 File type downloads file content twice when diffs are enabled Issue Type: Bug Assignee: Unassigned Created: 2015/01/27 4:38 PM Priority: Normal Reporter: Josh Cooper If puppet modifies a file (either via pluginsync or file source parameter), and you have show_diff enabled, then puppet will download the new file twice. First it downloads the file to a tempfile and runs diff against the tempfile and the old file. Then it downloads the file again, writes that to a different tempfile, and atomically renames the temp file over the old file: Suppose you have a module with a facts.d directory and a fact on your master: # cd /etc/puppet/modules/<module> # tree facts.d/ facts.d/ └── exec-fact.sh Run the agent, and you'll see 2 file_content requests: $ rm ~/.puppet/var/facts.d/exec-fact.sh $ touch ~/.puppet/var/facts.d/exec-fact.sh $ bundle exec puppet agent -td --http_debug 2>&1 >/dev/null | grep 'file_content' <- "GET /puppet/v3/file_content/pluginfacts/exec-fact.sh?environment=production& HTTP/1.1\r\nAccept: raw\r\nAccept-Encoding: gzip;q=1.0,deflate;q=0.6,identity;q=0.3\r\nUser-Agent: Ruby\r\nHost: arcturus.local:8140\r\n\r\n" <- "GET /puppet/v3/file_content/pluginfacts/exec-fact.sh?environment=production& HTTP/1.1\r\nAccept: raw\r\nAccept-Encoding: gzip;q=1.0,deflate;q=0.6,identity;q=0.3\r\nUser-Agent: Ruby\r\nHost: arcturus.local:8140\r\n\r\n" This is reproducible in 3.7.3, but has likely been around for awhile. Add Comment   This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.