Jira (PUP-4066) With strict variables turned on, it is difficult to use built in variables

[Henrik Lindberg (JIRA)]

Title: Message Title

Henrik Lindberg commented on PUP-4066   Re: With strict variables turned on, it is difficult to use built in variables The `defined('$::xyz')´ case not working may be a missing feature - how did you ensure the fact was set? The only other way to write that I can think of (in 3.x) is like this: class test ( $param = defined('$lsbdistcodename') ? { true => $lsbdistcodename, default => undef } ) { unless $param { fail('herp derp') } } shorter because there is no need for an extra variable, and IMO more readable. The select expr on the defined could be made into a function, e.g. unless_defined(varname, value), and the sample would then read: class test ( $param = unless_defined('$lsbdistcodename', undef) ) { unless $param { fail('herp derp') } } You could also fake $facts, in the initialization of your module set $mymodule::facts to $facts or to your own hash if it is not set. In this logic you do all the uness_defined calls (or messier equivalent). Then in all your logic in the module, simply refer to $mymodule::facts as a hash. This way, it is forward compatible, and you have all of the mess in one place. Add Comment   This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.