Jira (PUP-4127) Add migration check for type mismatch in case/selector options

[Henrik Lindberg (JIRA)]

Title: Message Title

Henrik Lindberg created an issue   Puppet / PUP-4127 Add migration check for type mismatch in case/selector options Issue Type: Sub-task Assignee: Unassigned Created: 2015/03/08 6:23 PM Priority: Normal Reporter: Henrik Lindberg In 4.0, comparison of String and Number is different (see PUP-4126). When there is a mismatch in case and selector options however, this leads to the option being skipped (there is never an error). The case and selector uses the evaluator_impl#is_match?, and it must check if the match is between Number and String. We also need to report the corner case of matching with regular expressions against something that is not a String. As illustrated here: $a = [1,2,3]   case $a { /2/ : { notice '3x herp derp' } default : { notice 'sane 4x' } } Add the issue MIGRATE4_OPTION_TYPE_MISMATCH to MigrationIssues with the text "#{the_uc(semantic) will never be selected since a value of type '#{left.class}}' cannot match a value of type '#{right.class}}' (3.x. may match if values in string form match)". Add a report_option_type_mismatch(test_value, option_value, option_expr, matching_expr) where the option_expr is the case or selector option/entry, and the matching_expr is the case option value _expression_ or the selector entry matching_expr (the selector entry only has one, the case option has multiple values that needs to be reported). Modify the is_match? method so it can pass the semantic objects on to the report method. Add Comment   This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.