Jira (PUP-4332) Resource properties frozen if copied from $title

[Craig Dunn (JIRA)]

Title: Message Title

Craig Dunn created an issue   Puppet / PUP-4332 Resource properties frozen if copied from $title Issue Type: Bug Affects Versions: PUP 3.7.3 Assignee: Unassigned Created: 2015/03/27 2:40 AM Priority: Normal Reporter: Craig Dunn There is some strange behaviour when creating user resources from a defined type via the create_resources function. Take this example; manifests/accounts.pp define account ( $comment = $title, $uid, ) {   user { $title: ensure => present, comment => $comment, } } Note that the $comment variable defaults to $title. The failure happens when you try and use create_resources to spin off instances of the account defined type without supplying comment.... "Working as expected" account { 'test1': uid => '2022' }   $accounts2 = { 'test23' => { 'uid' => '2024', 'comment' => 'foo' } } create_resources('account', $accounts2) However, if we use create_resources without the comment, I would expect the same behaviour I get when declaring the resource using the default for $comment (first example above), however this fails... $accounts = { 'test2' => { 'uid' => '2023' } } create_resources('account', $accounts)   Error: Parameter comment failed on User[troot]: Munging failed for value "troot" in class comment: can't modify frozen String at...   Wrapped exception: Munging failed for value "troot" in class comment: can't modify frozen String It looks like the This change as part of PUP-1473 highlighted the issue. It appears that in the last scenario, the comment parameter ends up a frozen string because it was copied from $title and this causes force_encoding to throw an error, but I only seem to observe this behaviour using create_resources. So although Im seeing the problem in the users type, I suspect the root cause to be elsewhere - the comment property should not be frozen, and why don't I get the same behaviour when declaring the resource directly? A module level work around is to quote the parameter in the defined resource type as: $comment = "${title}", The above passes all 3 tests These tests were run on puppet 3.7.3 ruby 2.0.0p353 Add Comment   This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.