Jira (PUP-927) puppet apply on Windows always uses *nix style newlines from templates

[Ethan Brown (JIRA)]

Title: Message Title

Ethan Brown commented on PUP-927   Re: puppet apply on Windows always uses *nix style newlines from templates Verifying with Rob's repo https://github.com/ferventcoder/puppet-simple_templates - existing files have the following checksums 2411f8af978939a25884d8e13ceb8b38 - crlf_newlines.txt 1751c05b07f0f4bc472fd04e6b9a5a5f - mixed_newlines.txt 2a8909a71df8f1216074d1bd295b8e8b - unix_newlines.txt   2411f8af978939a25884d8e13ceb8b38 - crlf_newlines.erb 1751c05b07f0f4bc472fd04e6b9a5a5f - mixed_newlines.erb 2a8909a71df8f1216074d1bd295b8e8b - unix_newlines.erb Tests are executed against the sample module Rob has provided with bundle exec puppet apply --modulepath="../test-modules" -e "include simple_templates" Ruby 2.1.5 + the code from 3.x branch, prior to the PR merge C:\source\puppet-2 [3.x...origin/3.x]> bundle exec puppet apply --modulepath="../test-modules" -e "include simple_templates" Notice: Compiled catalog for vagrant-2008r2.corp.puppetlabs.net in environment production in 0.22 seconds Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines]/ensure: created Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/unix_newlines_file.txt]/ensure: defined content as '{md5}2a8909a71df8f1216074d1bd295b8e8b' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/crlf_newlines_file.txt]/ensure: defined content as '{md5}2411f8af978939a25884d8e13ceb8b38' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/unix_newlines_template.txt]/ensure: defined content as '{md5}2a8909a71df8f1216074d1bd295b8e8b' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/mixed_newlines_file.txt]/ensure: defined content as '{md5}1751c05b07f0f4bc472fd04e6b9a5a5f' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/crlf_newlines_template.txt]/ensure: defined content as '{md5}cf8645a63ddea683c3fddc26f9f46e4d' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/mixed_newlines_template.txt]/ensure: defined content as '{md5}f1003c4d3bcab23138e1224e4a2dab09' Notice: Finished catalog run in 0.17 seconds Notice that the SHAs for crlf_newlines_template.txt and mixed_newlines_template.txt are not correct. Ruby 2.1.5 + the code from 3.x branch, after merging fixed code C:\source\puppet [3.x +13 ~0 -0 !]> bundle exec puppet apply --modulepath="../test-modules" -e "include simple_templates" Notice: Compiled catalog for vagrant-2008r2.corp.puppetlabs.net in environment production in 0.25 seconds Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines]/ensure: created Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/unix_newlines_file.txt]/ensure: defined content as '{md5}2a8909a71df8f1216074d1bd295b8e8b' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/crlf_newlines_file.txt]/ensure: defined content as '{md5}2411f8af978939a25884d8e13ceb8b38' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/unix_newlines_template.txt]/ensure: defined content as '{md5}2a8909a71df8f1216074d1bd295b8e8b' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/mixed_newlines_file.txt]/ensure: defined content as '{md5}1751c05b07f0f4bc472fd04e6b9a5a5f' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/crlf_newlines_template.txt]/ensure: defined content as '{md5}2411f8af978939a25884d8e13ceb8b38' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/mixed_newlines_template.txt]/ensure: defined content as '{md5}1751c05b07f0f4bc472fd04e6b9a5a5f' Notice: Finished catalog run in 0.16 seconds Notice that all the file SHAs are the same as the original - Puppet has not damaged any of the CRLF or mixed line endings. Ruby 1.9.3 + the code from 3.x branch, prior to the PR merge C:\source\puppet-2 [3.x...origin/3.x]> bundle exec puppet apply --modulepath="../test-modules" -e "include simple_templates" Notice: Compiled catalog for vagrant-2008r2.corp.puppetlabs.net in environment production in 0.23 seconds Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines]/ensure: created Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/unix_newlines_file.txt]/ensure: defined content as '{md5}2a8909a71df8f1216074d1bd295b8e8b' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/crlf_newlines_file.txt]/ensure: defined content as '{md5}2411f8af978939a25884d8e13ceb8b38' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/unix_newlines_template.txt]/ensure: defined content as '{md5}2a8909a71df8f1216074d1bd295b8e8b' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/mixed_newlines_file.txt]/ensure: defined content as '{md5}1751c05b07f0f4bc472fd04e6b9a5a5f' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/crlf_newlines_template.txt]/ensure: defined content as '{md5}cf8645a63ddea683c3fddc26f9f46e4d' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/mixed_newlines_template.txt]/ensure: defined content as '{md5}f1003c4d3bcab23138e1224e4a2dab09' Notice: Finished catalog run in 0.17 seconds Notice that the SHAs for crlf_newlines_template.txt and mixed_newlines_template.txt, like in the Ruby 2.1.5 example, are not correct. Ruby 1.9.3 + the code from 3.x branch, after merging fixed code C:\source\puppet [3.x +13 ~0 -0 !]> bundle exec puppet apply --modulepath="../test-modules" -e "include simple_templates" Notice: Compiled catalog for vagrant-2008r2.corp.puppetlabs.net in environment production in 0.30 seconds Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines]/ensure: created Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/unix_newlines_file.txt]/ensure: defined content as '{md5}2a8909a71df8f1216074d1bd295b8e8b' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/crlf_newlines_file.txt]/ensure: defined content as '{md5}2411f8af978939a25884d8e13ceb8b38' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/unix_newlines_template.txt]/ensure: defined content as '{md5}2a8909a71df8f1216074d1bd295b8e8b' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/mixed_newlines_file.txt]/ensure: defined content as '{md5}1751c05b07f0f4bc472fd04e6b9a5a5f' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/crlf_newlines_template.txt]/ensure: defined content as '{md5}2411f8af978939a25884d8e13ceb8b38' Notice: /Stage[main]/Simple_templates/File[c:/temp/newlines/mixed_newlines_template.txt]/ensure: defined content as '{md5}1751c05b07f0f4bc472fd04e6b9a5a5f' Notice: Finished catalog run in 0.11 seconds Notice that all the file SHAs are the same as the original - Puppet has not damaged any of the CRLF or mixed line endings. Add Comment   This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.