Jira (PUP-735) Status unchanged when "Could not apply complete catalog"

Josh Cooper (JIRA) Mon, 13 Apr 2015 22:49:45 -0700

Title: Message Title

Josh Cooper commented on

PUP-735

I think there is an issue with the original fix d0e4efa3fc. If a cycle is detected, Puppet::Configurer no longer calls Puppet::Transaction::Report#finalize_report prior to sending the report. I think this means the report summary metrics are incorrect. It would probably be more correct to do:

  def apply_catalog(catalog, options)

    report = options[:report]

    begin

      report.configuration_version = catalog.version

      benchmark(:notice, "Applied catalog") do

        catalog.apply(options)

end

    ensure

      report.finalize_report

end

    report

end

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-735) Status unchanged when "Could not apply complete catalog"

Reply via email to