Jira (PUP-4521) Pass agent-requested environment to external node classifiers

[Michael Smith (JIRA)]

Title: Message Title

Michael Smith created an issue   Puppet / PUP-4521 Pass agent-requested environment to external node classifiers Issue Type: Improvement Assignee: Unassigned Created: 2015/05/04 1:09 PM Fix Versions: PUP 4.2.0 Priority: Normal Reporter: Michael Smith There is currently no way to write an external node classifier (which is authoritative) that allows some agents - based on Facts - to override the node classifier with its own requested environment. A simple Fact-based classifier might be require 'puppet/node'   class Puppet::Node::FactClassifier < Puppet::Indirector::Code desc "Simple facts-based classification"   # Look for external node definitions. def find(request) name = request.key facts = Puppet::Node::Facts.indirection.find(name, :environment => request.environment) fact_values = if facts.nil? {} else facts.sanitize facts.to_data_hash['values'] end   node = Puppet::Node.new(name) if fact_values['test'] Puppet.info("Use agent-specified environment") node.environment = request.environment else Puppet.info("Use production environment") node.environment = 'production' end   node.fact_merge node end end The first request will not use the correct Facts, which may end up classifying it as production, and subsequent requests will send request.environment as production, losing the agent's configured environment. The simplest way to handle this is to add the configured environment as a new option of the request, so the classifier can use that information. Add Comment   This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.