Jira (PUP-4542) mandatory attributes on defined resource types are not required for virtual/exported resources

[Geoff Williams (JIRA)]

Title: Message Title

Geoff Williams created an issue   Puppet / PUP-4542 mandatory attributes on defined resource types are not required for virtual/exported resources Issue Type: Bug Affects Versions: PUP 3.7.4 Assignee: Eric Sorenson Components: Language, UX Created: 2015/05/07 8:05 PM Environment: 3.7.4 (Puppet Enterprise 3.7.2) CentOS release 6.6 (Final) Priority: Normal Reporter: Geoff Williams Overview When declaring a virtual or exported resource using defined resource types, Puppet does not raise an error if mandatory attributes are not supplied. Testcase Create a single text file with the content below and run with puppet apply define mytype($mandatory, $option=false) { notify {"hello":} }   @mytype{ "foo":} Expected result Compilation should fail with a message that $mandatory is required Actual result Compilation succeeds, no errors are raised. A virtual resource was created in the testcase but the same is true for exported resources too (@@) If the testcase is modified to supply an unknown parameter, compilation fails as expected: define mytype($mandatory, $option=false) { notify {"hello":} }   @mytype{ "foo": nothere => false, } Problems this causes Users are able to execute broken puppet code with no errors Its unclear that mandatory attributes are mandatory Delayed failure of exported resources, accompanied by a difficult troubleshooting procedure involving PuppetDB In the real-world, this behaviour makes it more difficult then it should be for users to work with virtual/exported resources Workaround Users must remember read documentation/source code to determine if attributes are required or not Proposed solution Declared virtual and exported resources should check that all mandatory parameters are supplied before allowing manifest compilation to succeed. Add Comment   This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.