Jira (PUP-2080) Support functions written in pp

[Henrik Lindberg (JIRA)]

Title: Message Title

Henrik Lindberg commented on PUP-2080   Re: Support functions written in pp Example 1: This https://github.com/puppetlabs/puppetlabs-apache/blob/master/lib/puppet/parser/functions/validate_apache_log_level.rb validation function in apache, can be implemented like this with a puppet function: function apache::validate_log_level($log_level) { unless log_level =~ /(emerg|alert|crit|error|warn|notice|info|debug|trace[1-8])/ { fail("Log level '${log_level}' is not one of the supported Apache HTTP Server log levels.") } } This function: https://github.com/puppetlabs/puppetlabs-apache/blob/master/lib/puppet/parser/functions/bool2httpd.rb Can be written like this in Puppet. function apache::bool2http($arg) { case $arg { false, undef, /(?i:false)/ : { 'Off' } true, /(?i:true)/ : { 'On' } default : { "$arg" } } } Not sure if these count as "trivial", but they should be much more easily implemented by someone that knows Puppet but not Ruby. Nicholas Fagerlund Are those two examples enough? While not the best of examples - I can imagine refactoring something like this: https://github.com/puppetlabs/puppetlabs-apache/blob/master/manifests/version.pp into a class and a function. The role of the apache::version class is basically to provide a cached computed $apache::version::default value. If there is a reason to be able to get the default version without including the class, it can be refactored into a separate function - e.g. apache::default_version and the class then becomes: class apache::version { $default = apache::default_version() } While the rest of the logic is instead in a function. This example is not ideal since there is no need in the apache module to get the default version without also setting the cached variable. If the class instead had initiated multiple similar variables it would make more sense to factor out the computation of the various values to get better separation of concerns. If anyone has an example of a module/logic containing repeated logic, let me know. Add Comment   This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.