Jira (PUP-4537) Transitory failure on rdoc specs in AppVeyor

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper commented on PUP-4537   Re: Transitory failure on rdoc specs in AppVeyor There are a number of different issues here: puppet doc which relies on rdoc is deprecated, replaced by puppet-strings. Re-running a failed PR will sometimes pass. Appveyor has the ability to archive artifacts. We should set LOG_SPEC_ORDER and log spec_order.txt when the build fails. We are using different sets of gems in appveyor and puppet's jenkins when running puppet specs on Windows. The former is doing bundle install --path .bundle --without development, and the latter is doing bundle install --path development extra. The former will cause msgpack, rack, and a few other gems to be installed. msgpack in particular requires the devkit, which appveyor provides. We don't do that in puppet's jenkins, because end users don't necessarily have devkit installed, e.g. when installing from MSI. We should update appveyor to exclude extra as well. Puppet's gem file confines the rdoc gem to platform :ruby, which really means non-windows. When the test is run on Windows, we end up loading the rdoc version bundled into ruby (ruby 2.1.6 includes rdoc 4.1.0), and not the rdoc gem version (which is currently 4.2.0). Note the latter gem is what gets installed when running bundle install --path .bundle --without development on non-Windows. $ bundle exec ruby -e 'require "rdoc"; puts RDoc::VERSION' 4.2.0 The particular error is occurring when trying to use rdoc on windows to generate HTML for a custom module. We had a similar problem with this test on windows awhile ago. See https://github.com/Iristyle/puppet/commit/676768645f13a19381f0d40aa7e253db7d6cc4a8 and comments in https://github.com/puppetlabs/puppet/pull/2829#issuecomment-47925792. The previous issue was because the win32-dir gem modifies Dir.pwd to return a native windows path containing backslashes. This confused rdoc 4.x's use of Pathname.relative_path_from, and that is failing in a slightly different way now. The error message No such file or directory @ rb_sysopen - C:/Users/appveyor/AppData/Local/Temp/1/rspecrun20150520-2016-1j2ig5k/rdoc_parser_tmp20150520-2016-129379q/doc/__/__/Users/appveyor/AppData/Local/Temp/1/rspecrun20150520-2016-1j2ig5k/rdoc_parser_tmp20150520-2016-129379q/modules/a_module/manifests/a_type_pp.html indicates we are trying to get the path of C:/Users/appveyor/AppData/Local/Temp/1/rspecrun20150520-2016-1j2ig5k/rdoc_parser_tmp20150520-2016-129379q/modules/a_module/lib/puppet/type/a_plugin_rb.html relative to C:/Users/appveyor/AppData/Local/Temp/1/rspecrun20150520-2016-1j2ig5k/rdoc_parser_tmp20150520-2016-129379q/doc. So I would expect something like this to work: C:\projects\puppet>bundle exec irb irb(main):001:0> require 'win32/dir' => true irb(main):002:0> require 'pathname' => false irb(main):003:0> file = Pathname.new('C:\Users\albert\AppData\Local\Temp\myfile') => #<Pathname:C:\Users\albert\AppData\Local\Temp\myfile> irb(main):004:0> root = Pathname.new(Dir.pwd) => #<Pathname:C:\projects\puppet> irb(main):005:0> file.relative_path_from(root) => #<Pathname:../../Users/albert/AppData/Local/Temp/myfile> But the double underscores __ in the error message makes me think something (appveyor?) is replacing .. with __? Add Comment   This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.