Jira (PUP-4653) The filebucket client uses v1 API URLs internally

[Felix Frank (JIRA)]

Title: Message Title

Felix Frank created an issue   Puppet / PUP-4653 The filebucket client uses v1 API URLs internally Issue Type: Improvement Affects Versions: PUP 2.7.23 Assignee: Felix Frank Components: Client Created: 2015/05/26 2:03 PM Fix Versions: PUP 4.2.0 Labels: community indirector Priority: Normal Reporter: Felix Frank Since the 0.25 days, the filebucket client in the form of Puppet::FileBucket::Dipper has interfaces with the indirector by constructing URLs in the following fashion: @rest_path = "https://#{server}:#{port}/#{environment}/file_bucket_file/" # then dest_path = "#{@rest_path}#{file_bucket_file.name}/#{files_original_path}" The indirector breaks this down into its fields in Puppet::Indirector::Request#set_uri_key. env, indirector, @key = URI.unescape(uri.path.sub(/^\//, '')).split('/',3) @key ||= '' self.environment = env unless env == '' All of this is quite unecessary because 1. the indirection implicitly follows from the indirected class 2. the environment is not significant for filebucket interactions (As an aside, the API does not construct URLs like this anymore, either - the environment is a parameter and not a part of the URI path. This is not important here, though, because these URLs never hit the wire. They are only for the benefit of the Indirector::Request class.) A consequence of this construct is that new indirector uses with URLs in keys will be misinterpreted by the Request class. It would be beneficial to transform these internally used URLs into a form that 1. confers only the necessary information to the indirector 2. does not clash with other possible URLs Add Comment   This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.