Jira (PUP-4652) 4420_pluginfacts test errantly references "agent"

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper commented on PUP-4652   Re: 4420_pluginfacts test errantly references "agent" The beaker magic is in https://github.com/puppetlabs/beaker/blob/master/lib/beaker/dsl/roles.rb#L110-L116. It defines methods, e.g. agent, on the TestCase class that correspond to the roles defined in the host file. If you have a single agent in your host file, the method returns the one host: => 30 if agent['platform'] =~ /windows/ 31 fact_content = win_fact 32 extension = '.bat' 33 else 34 fact_content = unix_fact (rdb:2) agent.class Unix::Host (rdb:2) agent['platform'] "el-7-x86_64" But if you have multiple agents, it returns an array, and that's apparently what puppetserver is doing causing the test to fail: => 30 if agent['platform'] =~ /windows/ 31 fact_content = win_fact 32 extension = '.bat' 33 else 34 fact_content = unix_fact tests/pluginsync/4420_pluginfacts_should_be_resolvable_on_agent.rb:30 if agent['platform'] =~ /windows/ (rdb:2) agent.class Array (rdb:2) agent['platform'] TypeError Exception: no implicit conversion of String into Integer (rdb:2) agent.map(&:name) ["agent", "agent2"] Add Comment   This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.