Jira (PUP-4698) Make fqdn_rand() Return A Numeric Instead of a String

[Nick Walker (JIRA)]

Title: Message Title

Nick Walker created an issue   Puppet / PUP-4698 Make fqdn_rand() Return A Numeric Instead of a String Issue Type: Improvement Assignee: Unassigned Created: 2015/06/04 2:25 PM Labels: tcse Priority: Normal Reporter: Nick Walker While testing the following snippet of code with the puppet 4 parser it would fail unexpectedly on only a few nodes. $cron_minute = fqdn_rand( 60 ) if ($cron_minute >= '60') { fail ("Variable cron_minute in module connection_watcher is >= 60. Values must be < 60. The cron_minute value is $cron_minute.") } Upon further research, I figured the issue was because of the comparison of two strings not working the same was as two integers would. So, changing over to numeric for the comparison resolves the issue. $cron_minute = 0 + fqdn_rand( 60 ) #change a string to a numeric type if ($cron_minute >= 60) { fail ("Variable cron_minute in module connection_watcher is >= 60. Values must be < 60. The cron_minute value is $cron_minute.") } It turns out the issue with the original code only shows up with the values 6, 7,8, and 9 because the comparison only compares the first two values of the string if they are of unequal lengths. At the end of the day it seems that fqdn_rand should just return a numeric as it will always be a number and is only a string for historical reasons. Add Comment   This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.