Jira (PUP-4521) Pass agent-requested environment to external node classifiers

[Eric Thompson (JIRA)]

Title: Message Title

Eric Thompson commented on PUP-4521   Re: Pass agent-requested environment to external node classifiers notes: when reproducing the fix... the enc above uses a fact to classify. so we need a custom fact named "true" that will be pluginsynced to the agents. this can live in any module's lib/facter dir. no need to include that module. to get the enc to classify in one run patch the enc in the description, thusly: 19,20c19,20 < Puppet.info("Use agent-specified environment") < node.environment = request.environment --- > Puppet.info("Use agent-specified environment. configured_env: #{request.options[:configured_environment]}") > node.environment = request.options[:configured_environment] ensure you start fresh with no pluginsyncs done. or clear the libdir on the agent, AND the yaml cache on the master, and restart the master before trying again. the nitty gritty is below: validated on redhat7 at stable SHA: 4de4750 [root@sivarjqh2nuq2bz puppet]# cat /usr/local/share/ruby/site_ruby/puppet/indirector/node/fact_classifier.rb require 'puppet/node'   class Puppet::Node::FactClassifier < Puppet::Indirector::Code desc "Simple facts-based classification"   # Look for external node definitions. def find(request) name = request.key facts = Puppet::Node::Facts.indirection.find(name, :environment => request.environment) fact_values = if facts.nil? {} else facts.sanitize facts.to_data_hash['values'] end   node = Puppet::Node.new(name) if fact_values['test'] Puppet.info("Use agent-specified environment. configured_env: #{request.options[:configured_environment]}") node.environment = request.options[:configured_environment] else Puppet.info("Use production environment") node.environment = 'production' end   node.fact_merge node end end [root@sivarjqh2nuq2bz puppet]# cat /etc/puppetlabs/code/environments/lolwut/manifests/site.pp notify{"test fact:$test":} notify{"$environment":} notify{'yep': message => "agent_specified_environment=$agent_specified_environment"}   [root@sivarjqh2nuq2bz ~]# rm -rf /opt/puppetlabs/puppet/cache/yaml/* on the agent: [root@gh2btj64wehqip2 puppet]# rm -rf /opt/puppetlabs/puppet/cache/lib/* [root@gh2btj64wehqip2 puppet]# puppet agent -t --server sivarjqh2nuq2bz.delivery.puppetlabs.net --environment lolwut Warning: Local environment: "lolwut" doesn't match server specified node environment "production", switching agent to "production". Info: Retrieving pluginfacts Info: Retrieving plugin Notice: /File[/opt/puppetlabs/puppet/cache/lib/facter]/ensure: created Notice: /File[/opt/puppetlabs/puppet/cache/lib/facter/test.rb]/ensure: defined content as '{md5}b82f0665af3a22d42b5ee126b8810474' Info: Loading facts Info: Caching catalog for gh2btj64wehqip2.delivery.puppetlabs.net Warning: Local environment: "production" doesn't match server specified environment "lolwut", restarting agent run with environment "lolwut" Info: Retrieving pluginfacts Info: Retrieving plugin Info: Loading facts Info: Caching catalog for gh2btj64wehqip2.delivery.puppetlabs.net Info: Applying configuration version '1433882972' Notice: test fact:true Notice: /Stage[main]/Main/Notify[test fact:true]/message: defined 'message' as 'test fact:true' Notice: lolwut Notice: /Stage[main]/Main/Notify[lolwut]/message: defined 'message' as 'lolwut' Notice: agent_specified_environment=lolwut Notice: /Stage[main]/Main/Notify[yep]/message: defined 'message' as 'agent_specified_environment=lolwut' Notice: Applied catalog in 0.03 seconds Add Comment   This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.