Jira (PUP-4825) Hashes and arrays are mutable via a function

Francois Lafont (JIRA) Tue, 07 Jul 2015 19:21:37 -0700

Title: Message Title

Francois Lafont created an issue

PUP-4825

Issue Type:	Bug
Affects Versions:	PUP 4.2.0
Assignee:	Unassigned
Components:	Language
Created:	2015/07/07 7:20 PM
Environment:	Updated Ubuntu Trusty 14.04 with Puppet server 4.2
Priority:	Normal
Reporter:	Francois Lafont

Hi,

I have seen PUP-1245, but here it's for Puppet 4.2 and the way to modify hashes or arrays is different. Here is my environment :

root@puppet4:~# lsb_release -a

No LSB modules are available.

Distributor ID:	Ubuntu

Description:	Ubuntu 14.04.2 LTS

Release:	14.04

Codename:	trusty

root@puppet4:~# type puppet

puppet is hashed (/opt/puppetlabs/bin/puppet)

root@puppet4:~# puppet -V

4.2.0

Here is the basic module to reproduce the bug:

root@puppet4:~# LC_ALL=C tree /puppet/production/modules/test/

/puppet/production/modules/test/

|-- lib

|   `-- puppet

|       `-- functions

|           `-- test

|               `-- foo.rb

`-- manifests

    `-- init.pp

Here is the content of init.pp:

class test ($a_hash, $an_array) {

  # join() is from the puppetlabs-stdlib and it's just to have

  # a readable printing of the array.

  notify { 'hash-before': message => $a_hash, }

  notify { 'array-before': message => $an_array.join('|'), }

  ::test::foo($a_hash, $an_array)

  notify { 'hash-after': message => $a_hash, }

  notify { 'array-after': message => $an_array.join('|'), }

Here is the content of foo.rb:

Puppet::Functions.create_function(:'test::foo') do

  dispatch :foo do

    param 'Hash', :a_hash

    param 'Array', :an_array

end

  def foo(a_hash, an_array)

    # We modify the parameters of this function but we

    # are just in the BODY of the function.

    a_hash['new'] = 'NEW'

    a_hash['a'] = 'BOUM!!!'

    an_array[0] = 'BOUM!!!'

    an_array[3] = 'NEW'

    true

end

end

Then, here is the content of site.pp

class { 'test':

  a_hash   => { 'a' => 'A', 'b' => 'B', },

  an_array => [ 'a', 'b', 'c' ],

Now, here is the result of a run puppet on the puppet server:

root@puppet4:~# puppet agent --test

Info: Retrieving pluginfacts

Info: Retrieving plugin

Info: Loading facts

Info: Caching catalog for puppet4.athome.priv

Info: Applying configuration version '1436321665'

Notice: {"a"=>"A", "b"=>"B"}

Notice: /Stage[main]/Test/Notify[hash-before]/message: defined 'message' as '{"a"=>"A", "b"=>"B"}'

Notice: a|b|c

Notice: /Stage[main]/Test/Notify[array-before]/message: defined 'message' as 'a|b|c'

Notice: {"a"=>"BOUM!!!", "b"=>"B", "new"=>"NEW"}

Notice: /Stage[main]/Test/Notify[hash-after]/message: defined 'message' as '{"a"=>"BOUM!!!", "b"=>"B", "new"=>"NEW"}'

Notice: BOUM!!!|b|c|NEW

Notice: /Stage[main]/Test/Notify[array-after]/message: defined 'message' as 'BOUM!!!|b|c|NEW'

Notice: Applied catalog in 0.11 seconds

The value of the hash and the value of the array have been changed in the calling puppet class test. Normally, modifications in the body of the function shouldn't change the state of the variables of the calling puppet class. Am I right?

Regards.

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-4825) Hashes and arrays are mutable via a function

Reply via email to