Jira (PUP-2573) Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not

[Shaigy Nixon (JIRA)]

Title: Message Title

Shaigy Nixon commented on PUP-2573   Re: Puppet::Agent::Locker#lock doesn't return whether it acquired the lock or not This is mostly an internal change and is adequately covered by the unit test. Manually validated whether running two agents simultaneously causes one to error out. Validated on puppet-agent SHA:9b28aee3e99572f4d98973d683592dc11239f8d6 On redhat-7-x86_64, output from two simultaneous runs: [root@h8vih00e5qmj3h3 ~]# puppet agent --test --server h8vih00e5qmj3h3.delivery.puppetlabs.net Info: Retrieving pluginfacts Info: Retrieving plugin Info: Caching catalog for h8vih00e5qmj3h3.delivery.puppetlabs.net Info: Applying configuration version '1436387833' Notice: Applied catalog in 0.01 seconds   [root@h8vih00e5qmj3h3 ~]# puppet agent --test --server h8vih00e5qmj3h3.delivery.puppetlabs.net Notice: Run of Puppet configuration client already in progress; skipping (/opt/puppetlabs/puppet/cache/state/agent_catalog_run.lock exists) On win2012r2-rubyx64: $ cmd /c puppet agent --test --server h8vih00e5qmj3h3.delivery.puppetlabs.net Info: Retrieving pluginfacts Info: Retrieving plugin Info: Caching catalog for nkjl3dzi8n6550p.delivery.puppetlabs.net Info: Applying configuration version '1436387977' Notice: Applied catalog in 0.19 seconds   $ cmd /c puppet agent --test --server h8vih00e5qmj3h3.delivery.puppetlabs.net Notice: Run of Puppet configuration client already in progress; skipping (C:/ProgramData/PuppetLabs/puppet/cache/state/agent_catalog_run.lock exists) On ubuntu-1404-x86_64 : root@wvm20aqr4gou8yz:~# puppet agent --test --server ljymxqdf5ra8dd8.delivery.puppetlabs.net Info: Retrieving pluginfacts Info: Retrieving plugin Info: Caching catalog for wvm20aqr4gou8yz.delivery.puppetlabs.net Info: Applying configuration version '1436391231' Notice: Applied catalog in 0.02 seconds   root@wvm20aqr4gou8yz:~# puppet agent --test --server ljymxqdf5ra8dd8.delivery.puppetlabs.net Notice: Run of Puppet configuration client already in progress; skipping (/opt/puppetlabs/puppet/cache/state/agent_catalog_run.lock exists) Add Comment   This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.