Jira (PUP-4050) Acceptance suite and install.rb use incorrect paths on Windows for codedir

[Ethan Brown (JIRA)]

Title: Message Title

Ethan Brown commented on PUP-4050   Re: Acceptance suite and install.rb use incorrect paths on Windows for codedir I spent a bit of time analyzing / understanding what's going on, and most of this is captured in the updated PR targeted at master - https://github.com/puppetlabs/puppet/pull/4088 I used baseline versions of the runs, then compared the Beaker hosts object by writing it to disk / diffing to see how puppetbindir, privatebindir, distmoduledir and sitemoduledir were being set with different Beaker flags, etc. Ultimately the simplest solution was to continue using the FOSS defaults and then to modify the distmoduledir and sitemoduledir for AIO once those nodes had been initially configured. This is confirmed correct, based on the fewest failures: failed: tests/ensure_puppet-agent_paths.rb errored: tests/config/puppet_manages_own_configuration_in_robust_manner.rb A couple of additional notes based on SSH'ing into Git provisioned nodes to verify pathing: Windows privatebindir, set to /usr/bin is the Cygwin bin dir, and includes things like git. When we install our custom Ruby, it also lives there. When we install Puppet, puppet.bat and puppet are there as well. However, /cygdrive/c/Program Files (x86)/Puppet Labs/Puppet/bin:/cygdrive/c/Program Files/Puppet Labs/Puppet/bin directories are never created as part of this Git install, so the puppetbindir setting for Windows agents is apparently meaningless. This probably means there are no Windows tests relying on puppetbindir - since it really should be /usr/bin For linux, /opt/puppetlabs/bin doesn't exist, nor does /opt/puppetlabs/puppet/bin, since this we're not installing AIO packages An improved solution might be to rework install.rb to use the expected AIO install dirs, rather than /usr/bin, but that is a much more involved solution. Add Comment   This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.