On Aug 26, 2008, at 1:56 PM, Brice Figureau wrote:
>
> This is the second attempt of a daemontools (only for the moment)
> provider for the service type. I added a rspec unit type, and tried
> to take into account all of Luke's previous comments.
This is great stuff, and I'd accept as-is.
In fact, the only comment I have is...
> +
> + # find the service dir on this node
> + def servicedir
> + unless defined?(@servicedir) and @servicedir
> + ["/service", "/etc/service","/var/lib/svscan"].each do |path|
> + if FileTest.exist?(path)
> + @servicedir = path
> + break
> + end
> + end
> + raise "Could not find service directory" unless @servicedir
> + end
> + @servicedir
> + end
> +
> + # returns the daemon dir on this node
> + def self.daemondir
> + self.class.defpath
> + end
Why is the servicedir (which is an instance method) mixed in with the
class methods like this? It makes me think there was a mistake
somewhere.
I'd prefer it be moved down to the other instance methods.
Obviously that's a really niggling point, though.
I can't tell indentation from email, but please make sure you're using
4-space indentation.
Great work.
--
I'm seventeen and I'm crazy. My uncle says the two always go together.
When people ask your age, he said, always say seventeen and insane.
-- Ray Bradbury
---------------------------------------------------------------------
Luke Kanies | http://reductivelabs.com | http://madstop.com
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
