On Sep 17, 2008, at 10:40 AM, Paul Nasrat wrote: > This is still for discussion, I'm aware that the tests are more like > integration tests, and I'd like to ensure the behaviour along with > unit testing > that it doesn't throw an exception. However this should give people > some sense > of progress. > > The use of recursion here is a little messy, as we want to not > return early on > a failure (in this case as FileTest.exists? is false for a dangling > symlink).
As I mention in one of my patch comments, it might actually be eaiser to just switch to using the Fileset class for recursion, since that's all it does and it's nicely encapsulated. It's pretty clear that the existing fileserving stuff is so messy it's very hard to maintain. -- I think that's how Chicago got started. A bunch of people in New York said, 'Gee, I'm enjoying the crime and the poverty, but it just isn't cold enough. Let's go west.' --Richard Jeni --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
