On 29/09/08 19:50, Luke Kanies wrote:
> On Sep 27, 2008, at 4:21 AM, Brice Figureau wrote:
> 
>> Hi,
>>
>> Here is a series of patch that modify Puppet parser to:
>> * add various operators (arithmetic, boolean...)
>> * add various number format knowledge to the lexer
>> * add the grammar to parse "complex" expressions
>>
>> Right now, the expressions can be use:
>> * in if tests:
>>
>>    Ex:
>>    if ($var < 10 + 0xff) and ($var2 == 10) {
>>
>> * in right value of assignements:
>>
>>    Ex:
>>    $var = 10 + 200 * -9 / (3 + $number)
>>
>> Please review and comment as usual :-)
>> The code has been pushed to my github repository:
>> http://github.com/masterzen/puppet/tree/feature%2Fexpression
> 
> 
> You kick ass, and just made a lot of people very happy. :)
> 
> I'll comment on individual patches as necessary; assume any  
> uncommented patches are acceptable to me.

OK, thanks.

I'll do a fix pass tomorrow with your comments, rebase/republish the 
branch (or adding a correction patch on top is enough for you?), then if 
you think it is OK, then you'll be free to merge :-)

And then, I'll have to find something else to work on :-)
If there are some things on which I can help, let me know.
-- 
Brice Figureau
Days of Wonder
http://www.daysofwonder.com

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to