On 17/10/08 17:18, David Schmitt wrote: > Brice Figureau schrieb: >> lib/puppet/parser/parser.rb | 1744 >> ++++++++++++++++++++------------------- > > Shouldn't this be excluded from the patch? I mean, it's generated > anyways and nobody does review that part, no?
From the patch maybe (it'd enhance the reviewability). From the changeset I don't think so, since I'm not sure James regenerate the parser each time (he does it in case of conflict, I'm sure). -- Brice Figureau Days of Wonder http://www.daysofwonder.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
