On Fri, 2008-10-17 at 13:50 +0200, duritong wrote:
> If you'd like to run puppetmaster in a mongrel cluster you have to start X
> instances of puppetmaster with servertype set to mongrel. With this patch
> you can add more than one port to the sysconfig file and puppetmaster will
> automatically be started with severtype set to mongrel.
> You can now even specify an alternate port in the sysconfig file on which
> puppetmaster should be run as webrick based server. See sysconfig file for
> more documentation.
Looks good. My one suggestion (which I also noted on the ticket):
The expression
[ -n "$PUPPETMASTER_PORTS" ] && [ [EMAIL PROTECTED] -gt
1 ]
turns up quite a bit. It would make the file more readable if that test
is done once at the beginning of the file, e.g.
[ -n "$PUPPETMASTER_PORTS" -a [EMAIL PROTECTED] -gt 1 ] &&
multiport=yes || multiport=no
and the rest of the file uses $multiport to distinguish between the
single port and the multiport case.
Other than that: ACK
David
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
