On Oct 12, 2008, at 4:25 AM, Brice Figureau wrote:
>
> Hi,
>
> Sorry if this ends by a double post, I sent it first with my regular
> e-mail address which is not subscribed to this list.
> Note, that I never received an e-mail I git sended yesterday whose
> subject starts with [PATCH 1/2] Fix #1088. I received the other two
> but
> this one seems to be stuck somewhere. I can see it in the web archive
> though, so that's quite strange (that's not the first time some google
> groups mails takes a long time to reach me).
>
> On 11/10/08 22:36, Luke Kanies wrote:
>> +1, but with comments below.
>>
>> On Oct 11, 2008, at 1:00 PM, Brice Figureau wrote:
>>> diff --git a/test/data/snippets/multipleclass.pp b/test/data/
>>> snippets/multipleclass.pp
>>> new file mode 100644
>>> index 0000000..fb363a1
>>> --- /dev/null
>>> +++ b/test/data/snippets/multipleclass.pp
>>> @@ -0,0 +1,9 @@
>>> +class one {
>>> +notice('class one')
>>> +}
>>> +
>>> +class one {
>>> +notice('second class one')
>>> +}
>>> +
>>> +include one
>>
>>
>> Shouldn't there be a test somewhere for this? Snippets without an
>> associated test method in test/language/snippets are ignored.
>
> Actually I didn't want to commit this file. It was my test file for
> debugging the issue. It just happens this directory is handy to drop
> such files.
>
> Anyway, I just pushed a rewrite of this file and the corresponding
> snippet test
> I'll update the other not merged tickets I just fixed that contains
> snippets with snippet tests, if you think it is necessary.
At the least, each snippet should have an empty test, since otherwise
the snippet is totally ignored. With an empty test, the snippet is at
least syntax-checked.
I'm not exactly thrilled with those tests, esp. since they all require
transactions and everything -- it'd be much better to test the
resulting catalog.
In the meantime, though, it'd be best to have a snippet test for each
of the syntax types.
>
>> That whole file should be migrated to spec/integration at some point,
>> of course.
>
> I think so, but I think I'll let you do it as it seems a quite complex
> task :-)
--
The point of living and of being an optimist, is to be foolish enough
to believe the best is yet to come. -- Peter Ustinov
---------------------------------------------------------------------
Luke Kanies | http://reductivelabs.com | http://madstop.com
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
