On Sun, 2008-11-02 at 22:04 -0600, Luke Kanies wrote: > I misunderstood your earlier comment about missing tests -- it's fine > if this file doesn't have any tests.
OK great. I wasn't really sure how to test this anyway. > I think it's time to refactor the file, though -- the case-statement- > based selection nearly always means it should be refactored into > simple classes with a dispatch method (e.g., a DocGenerator class, > with an instance that can generate trac docs and html docs etc.). OK, I'll try to see how I can do this. > It also seems like there are a lot of whitespace changes here; did you > change the indentation method? Only for the options array that was TAB tabulated and not space indented, and the old code is now indented because wrapped in an else branch. Also if you are a whitespace ayatollah, I can contribue a patch to trim trailing whitespaces or TABs in the whole puppet code (including some I introduced myself). I'm noticing them now that I have added trailing whitespace coloration in TextMate :-) > Otherwise, awesome. Thanks :-) > And if anyone wants to help make that CSS look a bit less awful, it'd > be great to differentiate ourselves from rdoc in how the generated > docs look. I'm really not an HTML/CSS guy so any help on this would be appreciated. > [snipped patch] > -- Brice Figureau <[EMAIL PROTECTED]> --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
