On Nov 25, 2008, at 7:26 PM, Nigel Kersten wrote: > > so Luke asked me to send this through. > > As an FYI before this starts... the directoryservice provider is in > major need of refactoring imho. It's kind of overloaded in the > nameservice provider, and Jeff McCune and I are planning to take a > step back and rethink the whole thing for post 0.24.x.
I completely agree. I'd go one step further and say the whole nameservice provider tree needs refactoring. What I was thinking was splitting it into modules -- generally, using modules instead of inheritance, where necessary. Really, the directoryservice stuff shouldn't use Etc, but it does currently, and if it no longer did, it wouldn't need to be related to the nameservice stuff at all, I think. For the rest of the nameservice stuff, I'm thinking the code that reads from Etc should be a module, then different providers can include and configure them, akin to how the providers configure ldap support in provider/user/ldap.rb. I think that's a great model. -- Every great advance in natural knowledge has involved the absolute rejection of authority. --Thomas H. Huxley --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---