This looks good so far, but I'll do more complete code review some time in the next week. I'm basically on vacation from now until New Year's, but I'll be trying to spend a bit of time on email anyway.
On Dec 22, 2008, at 1:26 PM, Brice Figureau wrote: > > Hi, > > This is a preliminary patch so that any volunteers (and especially > Luke) can > comment on it before I go to far in the wrong direction. > > The purpose of this patch is to: > * have a common framework for the executables to help manage options > or commands > * allow testing of the application code > > As I said earlier, this is preliminary stuff, so I only converted > two applications > (puppetca and filebucket) and I didn't provide any rspec test for > those (but the application > controller itself is fully covered). > > Please review and comment, so that I can continue the work which > blocks the > filebucket master changes I was doing :-) > > Thanks, > Brice > > Brice Figureau (3): > Introducing the Application Controller > Move filebucket to Puppet::Application > Move puppetca to Puppet::Application > > bin/filebucket | 108 +------------- > bin/puppetca | 86 +----------- > lib/puppet/application.rb | 147 +++++++++++++++++++ > lib/puppet/application/filebucket.rb | 80 ++++++++++ > lib/puppet/application/puppetca.rb | 68 +++++++++ > spec/unit/application.rb | 268 +++++++++++++++++++++++++ > +++++++++ > 6 files changed, 569 insertions(+), 188 deletions(-) > create mode 100644 lib/puppet/application.rb > create mode 100644 lib/puppet/application/filebucket.rb > create mode 100644 lib/puppet/application/puppetca.rb > create mode 100755 spec/unit/application.rb > > > > -- The covers of this book are too far apart. -- Ambrose Bierce --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
