Hi, I'm proud to announce I've finished my work on the Application Controller refactoring. It is based on (a rather) current master (so it is on top of #1405).
I tested all applications before the rebasing so I'm pretty confident of my original work. I didn't retest much after the rebase (except running the unit tests, of course). Please review, comment and merge ASAP (if it meets the various requirements), as the final rebase was really painful even though there wasn't too much modifications to the bin/. Once it will be merged, I'll finish the work, that is remove duplicated code in the various application setup, or the --debug and --verbose options handling (which for the moment is different for each application). Also, testing by someone else than me would be great, as there are tons of option combination and I couldn't test everything. The code is right now in my github repository, branch feature/appcontroller: http://github.com/masterzen/puppet/tree/feature/appcontroller Thanks, Brice Brice Figureau (22): Introducing the Application Controller Move PuppetCA to the Application Controller paradigm Move filebucket to the Application Controller paradigm Move puppet to the Application Controller paradigm Move puppetmasterd to Puppet::Application Move pi to the Application Controller paradigm Move puppetrun to Application Controller paradigm Move ralsh to the Application Controller paradigm Move puppetdoc to the Application Controller paradigm Move puppetd to the Application Controller paradigm OptionsParser based Puppet::Application Move puppetca to the new option system Move filebucket to the new option system Move pi to the new option system Move puppet to the new option system Move Puppetmasterd to the new option system Move puppetd to the new option system Move puppetdoc to the new option system Move puppetrun to the new option system Move ralsh to the new option system Move --version handling to Puppet::Application Remove --version handling from applications bin/filebucket | 122 +-------- bin/pi | 223 +-------------- bin/puppet | 191 +------------ bin/puppetca | 103 +------- bin/puppetd | 272 +----------------- bin/puppetdoc | 197 +------------- bin/puppetmasterd | 168 +----------- bin/puppetrun | 243 +---------------- bin/ralsh | 187 +------------ lib/puppet/application.rb | 302 +++++++++++++++++++ lib/puppet/application/filebucket.rb | 87 ++++++ bin/pi => lib/puppet/application/pi.rb | 102 +++---- lib/puppet/application/puppet.rb | 140 +++++++++ lib/puppet/application/puppetca.rb | 71 +++++ lib/puppet/application/puppetd.rb | 255 ++++++++++++++++ lib/puppet/application/puppetdoc.rb | 198 +++++++++++++ lib/puppet/application/puppetmasterd.rb | 133 +++++++++ lib/puppet/application/puppetrun.rb | 216 ++++++++++++++ lib/puppet/application/ralsh.rb | 166 +++++++++++ lib/puppet/util/settings.rb | 32 ++ spec/unit/application.rb | 417 +++++++++++++++++++++++++++ spec/unit/application/filebucket.rb | 220 ++++++++++++++ spec/unit/application/pi.rb | 84 ++++++ spec/unit/application/puppet.rb | 293 +++++++++++++++++++ spec/unit/application/puppetca.rb | 134 +++++++++ spec/unit/application/puppetd.rb | 479 +++++++++++++++++++++++++++++++ spec/unit/application/puppetdoc.rb | 343 ++++++++++++++++++++++ spec/unit/application/puppetmasterd.rb | 328 +++++++++++++++++++++ spec/unit/application/puppetrun.rb | 265 +++++++++++++++++ spec/unit/application/ralsh.rb | 230 +++++++++++++++ 30 files changed, 4456 insertions(+), 1745 deletions(-) create mode 100644 lib/puppet/application.rb create mode 100644 lib/puppet/application/filebucket.rb copy bin/pi => lib/puppet/application/pi.rb (74%) mode change 100755 => 100644 create mode 100644 lib/puppet/application/puppet.rb create mode 100644 lib/puppet/application/puppetca.rb create mode 100644 lib/puppet/application/puppetd.rb create mode 100644 lib/puppet/application/puppetdoc.rb create mode 100644 lib/puppet/application/puppetmasterd.rb create mode 100644 lib/puppet/application/puppetrun.rb create mode 100644 lib/puppet/application/ralsh.rb create mode 100755 spec/unit/application.rb create mode 100644 spec/unit/application/filebucket.rb create mode 100755 spec/unit/application/pi.rb create mode 100644 spec/unit/application/puppet.rb create mode 100644 spec/unit/application/puppetca.rb create mode 100755 spec/unit/application/puppetd.rb create mode 100755 spec/unit/application/puppetdoc.rb create mode 100644 spec/unit/application/puppetmasterd.rb create mode 100755 spec/unit/application/puppetrun.rb create mode 100644 spec/unit/application/ralsh.rb --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
