On Feb 14, 2009, at 10:45 AM, Brice Figureau wrote: > Hi, > > I'm proud to announce I've finished my work on the Application > Controller > refactoring. It is based on (a rather) current master (so it is on > top of #1405). > > I tested all applications before the rebasing so I'm pretty > confident of > my original work. I didn't retest much after the rebase (except > running > the unit tests, of course). > > Please review, comment and merge ASAP (if it meets the various > requirements), > as the final rebase was really painful even though there wasn't too > much > modifications to the bin/. > > Once it will be merged, I'll finish the work, that is remove > duplicated > code in the various application setup, or the --debug and --verbose > options handling (which for the moment is different for each > application). > > Also, testing by someone else than me would be great, as there are > tons of > option combination and I couldn't test everything. > > The code is right now in my github repository, branch feature/ > appcontroller: > http://github.com/masterzen/puppet/tree/feature/appcontroller
I'll only respond to commits that I think need commentary -- if there are any in this series without commentary, consider them having received a '+1'. I'll also be testing your branch today, as soon as I close the loop on this other mid-commit branch. -- Wear the old coat and buy the new book. -- Austin Phelps --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com To unsubscribe from this group, send email to puppet-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---