Someone asked in #puppet the other day why the operatingsystemrelease fact on RHEL was just the major release integer and on CentOS was the full release, including the minor portion. It seems to me that this inconsistency should not exist. If there's a good (or historical) reason for it, feel free to drop the second patch.
The first patch simply consolidates the logic for reading the release
file on CentOS, Fedora, oel, ovs, and RedHat operating systems, as the
only thing that ought to differ between them is the name of the
release file. Testing on oel and ovs would be good, since I don't
have access to either of those systems.
Lastly, I'm unsure if I should include an update to the CHANGELOG in
these patches. I imagine that would just increase the chances of
making James run into a merge conflict. But I'm happy to resend with
the CHANGELOG included if that's preferred.
Todd Zullinger (2):
Consolidate operatingsystemrelease for CentOS, Fedora, oel, ovs, and
RedHat
Fix operatingsystemrelease on Red Hat based distros
lib/facter/operatingsystemrelease.rb | 64 ++++++---------------------------
1 files changed, 12 insertions(+), 52 deletions(-)
--
Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Time may be a great healer, but it's a lousy beautician.
pgpW2t8VAxsgZ.pgp
Description: PGP signature
