In fact I just wanted to know if this seems to be the correct way to correct it before continuing to do the tests and it appears that it isn't. By the way I haven't add any function I've just used one that already exist in the class that could fix the bug, but if a refactoring is needed it is maybe the right time to do so. I will take a look at it tomorrow.
Thanks, -- Stéphan Gorget On Tue, Apr 28, 2009 at 10:23 PM, Brice Figureau <[email protected]> wrote: > > Hi Stéphan, > > I hate to say that, but I don't think that's the correct way to fix this > issue (and it is missing tests :-)). > > The main issue is that Type is using its own tag management instead of > relying on Puppet::Util::Tagging like the other parts of Puppet (which > use tags as strings instead of symbols). > > If you want to see how it could be fixed, you can have a look the the > tickets/master/2207 branch in my github repository: > http://github.com/masterzen/puppet/tree/tickets/master/2207 > > The patch is not complete as it lacks full RSpec coverage of the tagging > (which hasn't been ported from test/). > If you want to take over the patch and finish the test, go ahead, > othewise I'll try to find a few minutes tomorrow to finish it and post > it here. > > Thanks, > Brice > > On 28/04/09 16:02, Stéphan Gorget wrote: >> I don't know if it has already been send, because I think my workstation >> is not well configured. >> >> Signed-off-by: Stéphan Gorget <[email protected]> >> --- >> lib/puppet/type.rb | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/lib/puppet/type.rb b/lib/puppet/type.rb >> index 3118788..6628205 100644 >> --- a/lib/puppet/type.rb >> +++ b/lib/puppet/type.rb >> @@ -1782,6 +1782,7 @@ class Type >> tags = [tags] unless tags.is_a? Array >> >> tags = tags.collect { |t| t.intern } >> + self.tags = @tags >> >> return tags.find { |tag| @tags.include? tag } >> end > > > -- > Brice Figureau > http://www.masterzen.fr/ > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
