On Apr 30, 2009, at 10:43 AM, Brice Figureau wrote:
>
> On Thu, 2009-04-30 at 10:19 +0200, Stéphan Gorget wrote:
>> I installed ruby 1.8.6 with the same gems and still have a lot of
>> errors
>> (around 54).
>
> Yes, I managed to reproduce the failing tests, and also I've fixed
> some
> of them (I'll send the patch later this week).
>
> As Luke said earlier, it comes from
> inter-dependencies/ordering/interaction of tests.
> Basically all the test/language/snippets tests are failing because
> they're trying to use active_record which is initialized by the
> collection tests in test/language/parser.
>
> I could fix those by "proctecting" the various new indirector
> active_record save/find call with some "return unless
> Puppet[:storeconfigs]", but I don't think it is the proper way to fix
> those (in fact it seems that what puppet wants to do is to use caching
> on active_record which somewhat seems to be the default).
>
> I'm going to try harder to isolate the cause, but IMHO it seems that
> the
> asynchronous_storeconfig patchs produced those regressions.
There's probably a test that sets storeconfigs = true, which then sets
up everything to use ActiveRecord, and the test should unset these but
does not.
Even worse, setting 'storeconfigs = false' doesn't currently unset all
of the types, because I figured it was unnecessary (in a normal
process, you wouldn't normally do this).
So, if you find a test that sets storeconfigs to true, you've probably
found the culprit.
--
Between two evils, I always pick the one I never tried before.
-- Mae West
---------------------------------------------------------------------
Luke Kanies | http://reductivelabs.com | http://madstop.com
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
