+1 Has anyone looked at bringing our copy of event-loop up to the latest version? Anyone know if there's a benefit to doing so?
On May 24, 2009, at 10:53 AM, joel r wrote: > > diff --git a/lib/puppet/external/event-loop/event-loop.rb > b/lib/puppet/external/event-loop/event-loop.rb > index 17a520e..f295506 100644 > --- a/lib/puppet/external/event-loop/event-loop.rb > +++ b/lib/puppet/external/event-loop/event-loop.rb > @@ -74,9 +74,11 @@ class EventLoop > > @notify_src, @notify_snk = IO.pipe > > - # prevent file descriptor leaks > - @notify_src.fcntl(Fcntl::F_SETFD, Fcntl::FD_CLOEXEC) > - @notify_snk.fcntl(Fcntl::F_SETFD, Fcntl::FD_CLOEXEC) > + unless Puppet.features.windows? > + # prevent file descriptor leaks > + @notify_src.fcntl(Fcntl::F_SETFD, Fcntl::FD_CLOEXEC) > + @notify_snk.fcntl(Fcntl::F_SETFD, Fcntl::FD_CLOEXEC) > + end > > @notify_src.will_block = false > @notify_snk.will_block = false > @@ -244,6 +246,9 @@ class IO > > def will_block= (wants_blocking) > require "fcntl" > + > + return if Puppet.features.windows? > + > flags = fcntl(Fcntl::F_GETFL, 0) > if wants_blocking > flags &= ~Fcntl::O_NONBLOCK > > > -- The reasonable man adapts himself to the world; the unreasonable one persists in trying to adapt the world to himself. Therefore all progress depends on the unreasonable man. -- George Bernard Shaw --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
