James Turnbull wrote: > Marc Fournier wrote: >> Sure, I'll setup a branch on github once everyone has agreed on >> this last patch set. Or is it more convenient to squash all of them >> in a single one ? > > Squash I think.
While you're squashing and rebasing¹, would a few small cleanups be
worth adding in as well? I'm thinking about puppetTypeRArrow, which
doesn't seem to be defined anywhere. I think just replacing all uses
of it with puppetParamRArrow works.
The other cleanup I was thinking about is dropping the unused
puppetParen, puppetBrace matches/HiLinks and the puppetTypeBrace and
puppetDelimiter HiLinks. Is there any reason to keep those around?
¹ rebase -i might be handy here, or cherry-pick -n :)
--
Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
A fool's brain digests philosophy into folly, science into
superstition, and art into pedantry. Hence University education.
-- George Bernard Shaw
pgpnxu2jgeYro.pgp
Description: PGP signature
