Hi, This series of patch are bug fix against puppetdoc in rdoc mode reported lately.
Note, the patch 2/4 is a big patch, which modifies a large part of the grammar for what can appear to be a small benefit. I've thought to the issue and try several fixes for 3/4 but the simple and safest one was this. I recommend you read carefully the commit msg of 2/4 and 3/4, for a thorough background explanation. The whole code is in my github repository, branch tickets/master/2366: http://github.com/masterzen/puppet/tree/tickets/master/2366 Please review and comment as usual, Thanks, Brice Brice Figureau (4): Fix #2366 - puppetdoc was parsing classes in the wrong order Make sure the parser sees the correct line number Fix #2364 - Associates the correct comment to the right statement Allow boolean value for boolean cli parameter lib/puppet/parser/grammar.ra | 119 ++++++----- lib/puppet/parser/lexer.rb | 30 ++- lib/puppet/parser/parser.rb | 391 ++++++++++++++++++++--------------- lib/puppet/parser/parser_support.rb | 9 +- lib/puppet/util/rdoc/parser.rb | 3 +- lib/puppet/util/settings.rb | 2 + spec/unit/parser/lexer.rb | 48 ++++- spec/unit/util/settings.rb | 7 + 8 files changed, 356 insertions(+), 253 deletions(-) --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
